Skip to content

fix(bundler): clear env before calling wix, closes #4791#4819

Merged
lucasfernog merged 11 commits intodevfrom
fix/wix-clear-env
Oct 3, 2022
Merged

fix(bundler): clear env before calling wix, closes #4791#4819
lucasfernog merged 11 commits intodevfrom
fix/wix-clear-env

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner August 1, 2022 13:21
@lucasfernog lucasfernog requested a review from a team as a code owner August 1, 2022 13:45
@lucasfernog
Copy link
Member Author

I've finally tested this after bloating the environment variables and it does fix the ICE issues. Might not be enough for #4791 if the issue is something else though.

@lucasfernog lucasfernog merged commit 7c0fa1f into dev Oct 3, 2022
@lucasfernog lucasfernog deleted the fix/wix-clear-env branch October 3, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant