-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): Use cargo metadata
to detect the workspace root and target directory, closes #4632, #4928.
#4932
Conversation
Didn't notice that i opened it as a draft. Anywayyy not ready to merge (there is a TODO comment), but ready for review :) |
Might be a bit too crazy but if we see any issues with |
Let's hope we won't see any issues then 😂 |
ah whoops, it doesn't compile yet, sorryy |
So it does compile locally and the error in the workflow logs doesn't make any sense to me. |
ahhh i guess it's because of the new interface/rust/desktop.rs file - Why doesn't github scream at me because of merge conflicts or something :( |
It does some magic stuff merging with dev when testing lol |
6d1ceb8
to
a2b790b
Compare
Thanks for implementing it :) this is super helpful for the mobile implementation too, since cargo-mobile sets a target in .cargo/config. |
Actually I need to make a small change in the target option to fix that :D will work on that later |
cargo metadata
fails? If not i think we should return the PathBuf directly instead of a Result.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)