Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri) add plugin system for rust #494

Merged
merged 11 commits into from
Jul 12, 2020
Merged

feat(tauri) add plugin system for rust #494

merged 11 commits into from
Jul 12, 2020

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team March 7, 2020 13:20
@lucasfernog lucasfernog changed the title feat(tauri) add extension system feat(tauri) add plugin system Mar 8, 2020
@lucasfernog lucasfernog changed the title feat(tauri) add plugin system feat(tauri) add plugin system for rust Mar 8, 2020

pub trait Plugin {
#[allow(unused_variables)]
fn created(&self, webview: &mut WebView<'_, ()>) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need the ending {} not that it really matters.

@lucasfernog lucasfernog requested a review from a team as a code owner July 10, 2020 15:09
.changes/plugin-system.md Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 78afee9 into dev Jul 12, 2020
@lucasfernog lucasfernog deleted the feature/extensions branch April 28, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants