Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): load Cargo configuration to check default build target #4990

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is mostly useful for the future mobile implementation since cargo-mobile sets the default target in the Cargo configuration to avoid cache issues (we didn't check if the issues still exists though). See the commit.

@lucasfernog lucasfernog requested a review from a team as a code owner August 21, 2022 18:34
@lucasfernog lucasfernog merged commit 436f3d8 into dev Aug 21, 2022
@lucasfernog lucasfernog deleted the feat/cargo-config-target branch August 21, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants