Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add icon command (tauricon) #4992

Merged
merged 12 commits into from
Sep 3, 2022
Merged

feat(cli): Add icon command (tauricon) #4992

merged 12 commits into from
Sep 3, 2022

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary -> tauricon.js is breaking apart rn.

Other Information

I'll add some more info here after i got some sleep.

tooling/cli/Cargo.toml Outdated Show resolved Hide resolved
@FabianLars FabianLars marked this pull request as ready for review August 23, 2022 12:14
@FabianLars FabianLars requested a review from a team as a code owner August 23, 2022 12:14
@FabianLars
Copy link
Member Author

FabianLars commented Aug 23, 2022

Marked as ready for review as i don't have any changes for 1.1 planned anymore.

Only the rust-icns crate release is missing, and some testing on macos would be nice.

Edit: Oh and there's a TODO left about the input size, but we specified 1240 as a requirement for so long, i don't think it's really a problem to keep that for now, and it's not a hard requirement anyway, other sizes will work fine too🤷

@lucasfernog lucasfernog merged commit 12e9d81 into dev Sep 3, 2022
@lucasfernog lucasfernog deleted the feat/tauricon branch September 3, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants