Skip to content

fix(api): add async mockIPC() handler signature#5056

Merged
JonasKruckenberg merged 3 commits intodevfrom
JonasKruckenberg-patch-1
Aug 26, 2022
Merged

fix(api): add async mockIPC() handler signature#5056
JonasKruckenberg merged 3 commits intodevfrom
JonasKruckenberg-patch-1

Conversation

@JonasKruckenberg
Copy link
Copy Markdown
Member

The mockIPC() function accepted async functions and Promise returns from the beginning, but the handler function signature didn't reflect it.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The `mockIPC()` function accepted async functions and Promise returns from the beginning, but the handler function signature didn't reflect it.
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner August 26, 2022 08:08
@JonasKruckenberg JonasKruckenberg merged commit 4fa968d into dev Aug 26, 2022
@amrbashir amrbashir deleted the JonasKruckenberg-patch-1 branch September 15, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants