Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(endpoints/fs/readDir): don't read symlinks that are not allowed b… #5123

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

amrbashir
Copy link
Member

…y the scope, closes #4882

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 1, 2022 23:55
tweidinger
tweidinger previously approved these changes Sep 4, 2022
Copy link
Contributor

@tweidinger tweidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that I no longer can enumerate folders outside the configured scope. Good work @amrbashir 👍

@lucasfernog lucasfernog merged commit f4121c1 into dev Sep 8, 2022
@lucasfernog lucasfernog deleted the fix-readdir-symlink branch September 8, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Accessing junction folder from within $APP folder on Windows
3 participants