Skip to content

feat: expose set_title for MacOS tray#5182

Merged
lucasfernog merged 4 commits intotauri-apps:devfrom
vojty:feat-expose-set-title
Sep 30, 2022
Merged

feat: expose set_title for MacOS tray#5182
lucasfernog merged 4 commits intotauri-apps:devfrom
vojty:feat-expose-set-title

Conversation

@vojty
Copy link
Contributor

@vojty vojty commented Sep 13, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vojty vojty force-pushed the feat-expose-set-title branch from 9acf14e to 120c2ac Compare September 20, 2022 17:31
@vojty vojty marked this pull request as ready for review September 29, 2022 18:45
@vojty vojty requested a review from a team as a code owner September 29, 2022 18:45
@vojty
Copy link
Contributor Author

vojty commented Sep 30, 2022

Any help on finishing this PR would be appreciated.

Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

@lucasfernog
Copy link
Member

Would be really really nice if you could setup commit signing for next time, but nice PR ❤️

@lucasfernog lucasfernog merged commit 8f1ace7 into tauri-apps:dev Sep 30, 2022
@vojty
Copy link
Contributor Author

vojty commented Sep 30, 2022

wow I didn't expect so quick reaction, thanks a lot ❤️

@fcoury
Copy link

fcoury commented Oct 8, 2022

I am currently using this feature, and loving it.

Quick question though: is there a way already or are you planning on allowing usage of the tray with no icons, just text?

@FabianLars
Copy link
Member

@fcoury Feel free to open a feature request for that one ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants