Skip to content

fix(codegen): serialize template tags, closes #4410 - #5247

Merged
lucasfernog merged 1 commit into
devfrom
fix/template-html
Sep 28, 2022
Merged

lucasfernog merged 1 commit into
devfrom
fix/template-html

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog
lucasfernog requested a review from a team as a code owner September 20, 2022 16:52
@lucasfernog

Copy link
Copy Markdown
Member Author

Closes #4410

@lucasfernog lucasfernog changed the title fix(codegen): serialize template tags fix(codegen): serialize template tags, closes #4410 Sep 20, 2022
@TonyLuo

TonyLuo commented Sep 25, 2022

Copy link
Copy Markdown

hi @lucasfernog , I am trying to use tauri with vue 3, may I know when will this fix be released?

@TonyLuo

TonyLuo commented Sep 25, 2022 •

Copy link
Copy Markdown

I tried to use branch fix/template-html, but vue-router didn't work when build into bundle, it only worked in tauri dev mode

[package]
name = "app"
version = "0.1.0"
description = "app Client"
authors = ["you"]
license = ""
repository = ""
default-run = "app"
edition = "2021"
rust-version = "1.57"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[build-dependencies]
# tauri-build = { version = "1.1.1", features = [] }
tauri-build = { git = "https://github.com/tauri-apps/tauri", branch = "fix/template-html", features = [] }

# [dependencies]
# serde_json = "1.0"
# serde = { version = "1.0", features = ["derive"] }
# tauri = { version = "1.1.1", features = ["http-all", "shell-all", "system-tray", "window-all"] }
[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
# tauri = { version = "1.1.1", features = ["http-all", "shell-all", "system-tray", "window-all"] }
tauri = { git = "https://github.com/tauri-apps/tauri", branch = "fix/template-html", features = ["http-all", "shell-all", "system-tray", "window-all"] }
# cocoa = "0.24.0"
window-vibrancy = "0.3.0"
window-shadows = "0.2.0"
percent-encoding = "^2.2"
# tauri-plugin-positioner = {git = "https://github.com/JonasKruckenberg/tauri-plugin-positioner", branch = "main"}
# tauri-plugin-localhost = "0.1.0"
# portpicker = "0.1"

[dependencies.tauri-plugin-store]
git = "https://github.com/tauri-apps/tauri-plugin-store"
branch = "dev"
[features]
# by default Tauri runs in production mode
# when `tauri dev` runs it is executed with `cargo run --no-default-features` if `devPath` is an URL
default = [ "custom-protocol" ]
# this feature is used used for production builds where `devPath` points to the filesystem
# DO NOT remove this
custom-protocol = [ "tauri/custom-protocol" ]

[target."cfg(any(target_os = \"ios\", target_os = \"macos\"))".dependencies]
cocoa = "0.24.0"

@lucasfernog

Copy link
Copy Markdown
Member Author

We're planning a patch next week.

@lucasfernog

Copy link
Copy Markdown
Member Author

@TonyLuo please file a separate issue with a repo we can use to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants