fix(api): fs/exists return type previously set to void when it should be boolean #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Sep 21, 2022
|
@amrbashir As mentioned in the bottom of the PR, the link to the docs is dead. Is there an up-to-date documentation you could point me to for how to proceed with change files? I'm unfamiliar with this process. |
|
Here's the file in question: https://github.com/tauri-apps/tauri/blob/f5f9f105f768c0a0b86009c4a9058ce28563211d/.changes/readme.md |
Sorry about that, I didn't notice your note in the PR, I will fix that. and for now, use the link Fabian provided. |
keraf
force-pushed
the
fix/exists-return-type
branch
from
186a843
to
c249200
Compare
|
Thanks! I have now added the change file. |
amrbashir
approved these changes
Sep 21, 2022
lucasfernog
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small fix to the
fs/existsmethod in the JS API, commit message should be explanatory enough 🙂Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Question regarding the second point in the checklist of PRs: How does it work? The link to the doc is dead. Would love to add the file in this or future PRs if required.