Skip to content

fix(api): fs/exists return type previously set to void when it should be boolean - #5252

Merged
lucasfernog merged 1 commit into
tauri-apps:devfrom
keraf:fix/exists-return-type
Sep 29, 2022
Merged

fix(api): fs/exists return type previously set to void when it should be boolean#5252
lucasfernog merged 1 commit into
tauri-apps:devfrom
keraf:fix/exists-return-type

Conversation

@keraf

@keraf keraf commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

Very small fix to the fs/exists method in the JS API, commit message should be explanatory enough 🙂

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Question regarding the second point in the checklist of PRs: How does it work? The link to the doc is dead. Would love to add the file in this or future PRs if required.

@keraf
keraf requested a review from a team as a code owner September 21, 2022 09:46

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you also add a changefile in .changes folder?

@keraf

keraf commented Sep 21, 2022

Copy link
Copy Markdown
Contributor Author

@amrbashir As mentioned in the bottom of the PR, the link to the docs is dead. Is there an up-to-date documentation you could point me to for how to proceed with change files? I'm unfamiliar with this process.

@FabianLars

Copy link
Copy Markdown
Member

Here's the file in question: https://github.com/tauri-apps/tauri/blob/f5f9f105f768c0a0b86009c4a9058ce28563211d/.changes/readme.md
Was deleted by accident in #4351

@amrbashir

Copy link
Copy Markdown
Member

As mentioned in the bottom of the PR, the link to the docs is dead

Sorry about that, I didn't notice your note in the PR, I will fix that. and for now, use the link Fabian provided.

@keraf
keraf force-pushed the fix/exists-return-type branch from 186a843 to c249200 Compare September 21, 2022 12:01
@keraf

keraf commented Sep 21, 2022

Copy link
Copy Markdown
Contributor Author

Thanks! I have now added the change file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants