feat(api): add app-specific directory APIs, closes #5263#5272
feat(api): add app-specific directory APIs, closes #5263#5272lucasfernog merged 13 commits intotauri-apps:devfrom
Conversation
amrbashir
left a comment
There was a problem hiding this comment.
In particular, should there be tests? I can't find tests anywhere for similar API features such as the existing
appDirmethod.
It is fine, these functions don't have tests.
Also, are you happy with the way I have refactored
appDirandlogDirto internally callappConfigDirandappLogDirto avoid duplicated code?
Yeah that's perfect.
I also wondered if there's an equivalent to
@sincefor the Rust documentation comments?
I don't think there is but it is not needed. We are using @since in the js docs because we on
|
Another thing we need to think about is localdata vs data because of windows :/ |
|
yeah we could also add |
|
Thanks for the review @amrbashir, I'll make those changes later. I was actually going to ask about deprecation notices too but forgot, so thanks for mentioning that. I'll look at |
|
I think I've addressed all the issues discussed, and also fixed the lint error. Would you mind taking another look @amrbashir ? |
amrbashir
left a comment
There was a problem hiding this comment.
Also missing change file, should be a minor bump
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
I'd appreciate some feedback on the approach taken here as it's my first time working with the Tauri codebase.
In particular, should there be tests? I can't find tests anywhere for similar API features such as the existing
appDirmethod.Also, are you happy with the way I have refactored
appDirandlogDirto internally callappConfigDirandappLogDirto avoid duplicated code?I also wondered if there's an equivalent to
@sincefor the Rust documentation comments?What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
closes #5263