Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose user_agent to window config #5317

Merged
merged 8 commits into from
Oct 2, 2022

Conversation

emhagman
Copy link
Contributor

@emhagman emhagman commented Oct 1, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Requested here: #3904

  • Allow setting userAgent in the config file for any window
  • Added example under examples/user-agent
{
    "windows": [
      {
        "title": "Welcome to Tauri!",
        "width": 800,
        "height": 600,
        "resizable": true,
        "fullscreen": false,
        "userAgent": "Tauri 1.0 (Custom Agent)"
      }
    ]
}

Screenshots

Before After
CleanShot 2022-10-01 at 11 52 13@2x CleanShot 2022-10-01 at 11 38 05@2x

@emhagman emhagman requested a review from a team as a code owner October 1, 2022 15:45
@emhagman emhagman mentioned this pull request Oct 1, 2022
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution, thank you so much!

@lucasfernog lucasfernog merged commit a6c9411 into tauri-apps:dev Oct 2, 2022
@emhagman
Copy link
Contributor Author

emhagman commented Oct 2, 2022

@lucasfernog Thanks! And thanks for the tweaks, I'll be sure to follow that pattern next time 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants