Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialog.save return type #5373

Merged
merged 3 commits into from Oct 8, 2022
Merged

Fix dialog.save return type #5373

merged 3 commits into from Oct 8, 2022

Conversation

probablykasper
Copy link
Member

@probablykasper probablykasper commented Oct 8, 2022

Can return null when user cancels save dialog

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Can return `null` when user cancels save dialog
@probablykasper probablykasper requested a review from a team as a code owner Oct 8, 2022
tooling/api/src/dialog.ts Outdated Show resolved Hide resolved
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@lucasfernog lucasfernog merged commit 8357ce5 into dev Oct 8, 2022
5 checks passed
@lucasfernog lucasfernog deleted the dialog-save-return-fix branch Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants