Skip to content

Fix dialog.save return type#5373

Merged
lucasfernog merged 3 commits intodevfrom
dialog-save-return-fix
Oct 8, 2022
Merged

Fix dialog.save return type#5373
lucasfernog merged 3 commits intodevfrom
dialog-save-return-fix

Conversation

@probablykasper
Copy link
Copy Markdown
Member

Can return null when user cancels save dialog

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Can return `null` when user cancels save dialog
@probablykasper probablykasper requested a review from a team as a code owner October 8, 2022 03:56
Comment thread tooling/api/src/dialog.ts Outdated
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@lucasfernog lucasfernog merged commit 8357ce5 into dev Oct 8, 2022
@lucasfernog lucasfernog deleted the dialog-save-return-fix branch October 8, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants