Skip to content

fix(tauri): add missing generics on AppHandle and App#5642

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
oscartbeaumont:add-missing-generics
Nov 17, 2022
Merged

fix(tauri): add missing generics on AppHandle and App#5642
lucasfernog merged 2 commits intotauri-apps:devfrom
oscartbeaumont:add-missing-generics

Conversation

@oscartbeaumont
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

image

I found this issue in a project I am working on that depends on Tauri version 1.2.0.

@oscartbeaumont oscartbeaumont requested a review from a team as a code owner November 17, 2022 18:09
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@lucasfernog lucasfernog merged commit ed43ff3 into tauri-apps:dev Nov 17, 2022
@oscartbeaumont oscartbeaumont deleted the add-missing-generics branch November 27, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants