fix(cli): corrupted icons in bundled macOS icons #5698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
If there's a reason why we can't use these 2 icon types there would be 2 alternatives.
One only works on Big Sur and above and the other one works in older versions afaik but is undocumented (writing RGB data into PNG fields) and would require a somewhat bigger change in rust-icns.
Check https://en.wikipedia.org/wiki/Apple_Icon_Image_format if you need nightmare material.