Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): corrupted icons in bundled macOS icons #5698

Merged
merged 2 commits into from
Nov 28, 2022
Merged

fix(cli): corrupted icons in bundled macOS icons #5698

merged 2 commits into from
Nov 28, 2022

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

If there's a reason why we can't use these 2 icon types there would be 2 alternatives.
One only works on Big Sur and above and the other one works in older versions afaik but is undocumented (writing RGB data into PNG fields) and would require a somewhat bigger change in rust-icns.

Check https://en.wikipedia.org/wiki/Apple_Icon_Image_format if you need nightmare material.

@FabianLars FabianLars requested a review from a team as a code owner November 25, 2022 20:45
wusyong
wusyong previously approved these changes Nov 26, 2022
@lucasfernog lucasfernog merged commit 2d545ef into dev Nov 28, 2022
@lucasfernog lucasfernog deleted the icns branch November 28, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants