Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add support for Cargo's workspace inheritance for the package version, closes #5070 #5775

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented Dec 7, 2022

This could've been solved with the cargo metadata output (it reports the calculated version of all ws packages) but since we likely need this type of implementation for the dependency inheritance (see Other Information) i opted for copying part of cargo's source code instead. Edit: Nevermind, it seems to be different / easier to deserialize since it will be just another key in an already used map, so just tell me which version you'd prefer.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary - supporting cargo's features = good :)

Other Information

workspace inheritance for dependencies (tauri) will be a bit more involved and needs some planning first (we need to decide which behavior we'd like) so this will come in a separate PR at some point later.

@FabianLars FabianLars requested a review from a team as a code owner December 7, 2022 17:45
@lucasfernog lucasfernog merged commit cd8c074 into dev Dec 14, 2022
@lucasfernog lucasfernog deleted the feat/workspace-version branch December 14, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants