feat(cli): add support for Cargo's workspace inheritance for the package version, closes #5070#5775
Merged
lucasfernog merged 3 commits intodevfrom Dec 14, 2022
Merged
Conversation
…age version, closes #5070
lucasfernog
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could've been solved with the
cargo metadataoutput (it reports the calculated version of all ws packages) but since we likely need this type of implementation for thedependency inheritance (seeEdit: Nevermind, it seems to be different / easier to deserialize since it will be just another key in an already used map, so just tell me which version you'd prefer.Other Information) i opted for copying part of cargo's source code instead.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other Information
workspace inheritance for dependencies (tauri) will be a bit more involved and needs some planning first (we need to decide which behavior we'd like) so this will come in a separate PR at some point later.