Support sending raw byte data to the "data" event for child command's stdout and stderr by cymruu · Pull Request #5789 · tauri-apps/tauri

cymruu · 2022-12-08T22:37:09Z

What kind of change does this PR introduce?

Support sending raw byte data to the "data" event for child command's stdout and stderr. Still WIP

Does this PR introduce a breaking change?

Yes, and the changes were approved in issue [feat] Support sending byte data to the "data" event for child command's stdout and stderr #5465
No

Checklist

When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
I have added a convincing reason for adding this feature, if necessary

Other information

Closes #5465

core/tauri/src/api/process/command.rs

core/tauri/src/endpoints/shell.rs

core/tauri/src/api/process/command.rs

core/tauri/src/endpoints/shell.rs

cymruu · 2022-12-12T21:00:43Z

@amrbashir I have addressed your comments. Thank you for reviewing!

amrbashir

Since this is a breaking change and will be merged into next, can you rebase the changes in top of the next branch?

core/tauri/src/api/process/command.rs

core/tauri/src/endpoints.rs

tooling/api/src/shell.ts

amrbashir

LGTM. Thanks! I will leave the final review and merge to lucas.

lucasfernog · 2022-12-13T17:39:51Z

Looks really good. I'll make some tests and see if we can improve the api types.

lucasfernog · 2022-12-13T18:51:06Z

Let me know what you think about my change :P I'm not a TypeScript expert but I tried to let it infer most of the types from the encoding argument.

cymruu · 2022-12-19T09:27:04Z

@lucasfernog thank you for the improvement with result type inferring. I love it! I have merged with nextbranch again.

BTW what is the reason behind bundle.global.js being included in the repository?

FabianLars · 2022-12-19T09:29:39Z

bundle.global.js powers the withGlobalTauri (= the apis in window.__TAURI__). Building/Bundling that on the dev's machine is not really an option

cymruu · 2023-02-08T21:44:32Z

@lucasfernog @FabianLars Is the feature still needed? Is there anything else I can do regarding the PR?
I'm happy to help 🙂

lucasfernog · 2023-02-09T15:47:08Z

I just need some time to test this, my idea was to wait for 1.3 to launch before merging it since you already merged dev into this.

lucasfernog · 2023-03-31T15:51:46Z

Amazing work!

cymruu commented Dec 8, 2022

View reviewed changes

core/tauri/src/api/process/command.rs Outdated Show resolved Hide resolved

amrbashir reviewed Dec 9, 2022

View reviewed changes

core/tauri/src/api/process/command.rs Outdated Show resolved Hide resolved

cymruu added 10 commits December 12, 2022 17:07

implement raw encoding type

bee7662

fix tests

b257f69

add tests for raw encoding

70a095b

add tests for command::output method

8ee59e7

fix example in doc

a464d37

shell.ts collectEvents method

e573da1

implement raw data result for output method

5c55311

implement JSCommandEvent

a5e48ff

remove EncodingWrapper from Command

b92796c

remove unused Buffer to_bytes method

c3db0cd

cymruu force-pushed the cymruu/command-byte-data branch from 06f74c2 to c3db0cd Compare December 12, 2022 16:36

cymruu commented Dec 12, 2022

View reviewed changes

core/tauri/src/endpoints/shell.rs Show resolved Hide resolved

cymruu added 2 commits December 12, 2022 21:14

fmt

e6d6b00

fix clippy warnings

d31ce3d

amrbashir requested changes Dec 12, 2022

View reviewed changes

core/tauri/src/api/process/command.rs Outdated Show resolved Hide resolved

core/tauri/src/api/process/command.rs Outdated Show resolved Hide resolved

core/tauri/src/endpoints/shell.rs Outdated Show resolved Hide resolved

address code-review comments

e28cfe2

amrbashir requested changes Dec 12, 2022

View reviewed changes

core/tauri/src/api/process/command.rs Outdated Show resolved Hide resolved

core/tauri/src/endpoints.rs Outdated Show resolved Hide resolved

tooling/api/src/shell.ts Outdated Show resolved Hide resolved

tooling/api/src/shell.ts Outdated Show resolved Hide resolved

cymruu force-pushed the cymruu/command-byte-data branch from e28cfe2 to f84ac44 Compare December 13, 2022 09:42

cymruu changed the base branch from dev to next December 13, 2022 09:42

cymruu added 2 commits December 13, 2022 10:48

address code-review comments 2

05b3c6f

Merge branch 'next' into cymruu/command-byte-data-rebase

af4e3c7

cymruu force-pushed the cymruu/command-byte-data branch from f84ac44 to af4e3c7 Compare December 13, 2022 09:49

cymruu marked this pull request as ready for review December 13, 2022 09:52

cymruu requested review from a team as code owners December 13, 2022 09:52

amrbashir previously approved these changes Dec 13, 2022

View reviewed changes

improve type

bf2c840

lucasfernog dismissed amrbashir’s stale review via bf2c840 December 13, 2022 18:50

lucasfernog and others added 3 commits December 13, 2022 15:52

fmt

540cc7a

update bundle.global.js

14be599

Merge branch 'next' into cymruu/command-byte-data

7bcedc5

cymruu added 5 commits December 19, 2022 10:39

update bundle.global.js

628d7d0

Merge branch 'next' into cymruu/command-byte-data

9203cc2

Merge branch 'next' into cymruu/command-byte-data

f747e3c

Merge branch 'next' into cymruu/command-byte-data

496494e

Merge branch 'next' into cymruu/command-byte-data

3a44f6b

fmt

6c11999

cymruu force-pushed the cymruu/command-byte-data branch from a5a713c to 6c11999 Compare February 8, 2023 22:03

cymruu added 2 commits March 30, 2023 17:28

Merge branch 'next' into cymruu/command-byte-data

af710b0

run eslint --fix

55b9575

cymruu force-pushed the cymruu/command-byte-data branch from f44b3a9 to 55b9575 Compare March 30, 2023 15:39

cleanup [skip ci]

b2fde0a

lucasfernog previously approved these changes Mar 31, 2023

View reviewed changes

add change file [skip ci]

b95231b

lucasfernog dismissed their stale review via b95231b March 31, 2023 15:51

lucasfernog approved these changes Mar 31, 2023

View reviewed changes

lucasfernog merged commit 509d467 into tauri-apps:next Mar 31, 2023

Uh oh!

Conversation

cymruu commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Checklist

Other information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cymruu commented Dec 12, 2022

Uh oh!

amrbashir left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amrbashir left a comment

Choose a reason for hiding this comment

Uh oh!

lucasfernog commented Dec 13, 2022

Uh oh!

lucasfernog commented Dec 13, 2022

Uh oh!

cymruu commented Dec 19, 2022

Uh oh!

FabianLars commented Dec 19, 2022

Uh oh!

cymruu commented Feb 8, 2023

Uh oh!

lucasfernog commented Feb 9, 2023

Uh oh!

lucasfernog commented Mar 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cymruu commented Dec 8, 2022 •

edited

Loading

amrbashir left a comment •

edited

Loading