feat(core): expose additional_browser_args to window config (fix: #5757)#5799
Merged
lucasfernog merged 4 commits intotauri-apps:devfrom Dec 14, 2022
noamzaks:additional-browser-args
Merged
feat(core): expose additional_browser_args to window config (fix: #5757)#5799lucasfernog merged 4 commits intotauri-apps:devfrom noamzaks:additional-browser-args
lucasfernog merged 4 commits intotauri-apps:devfrom
noamzaks:additional-browser-args
Conversation
amrbashir
requested changes
Dec 9, 2022
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Thank you, just a few nit-picks and should be good to go
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
previously approved these changes
Dec 9, 2022
Member
|
I think we should document the default value like we do in wry: https://docs.rs/wry/latest/x86_64-pc-windows-msvc/wry/webview/trait.WebViewBuilderExtWindows.html#tymethod.with_additional_browser_args |
lucasfernog
approved these changes
Dec 14, 2022
lucasfernog
added a commit
that referenced
this pull request
Feb 8, 2023
This was introduced in #5799, but it's dangerous to let the frontend set this option.
13 tasks
This was referenced Mar 1, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Could probably help various use cases, including mine in #5757.
Discord thread.