Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): expose additional_browser_args to window config (fix: #5757) #5799

Merged
merged 4 commits into from
Dec 14, 2022
Merged

feat(core): expose additional_browser_args to window config (fix: #5757) #5799

merged 4 commits into from
Dec 14, 2022

Conversation

noamzaks
Copy link
Contributor

@noamzaks noamzaks commented Dec 9, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Could probably help various use cases, including mine in #5757.

Discord thread.

@noamzaks noamzaks requested a review from a team as a code owner December 9, 2022 16:13
amrbashir
amrbashir requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just a few nit-picks and should be good to go

core/tauri-runtime/src/webview.rs Outdated Show resolved Hide resolved
core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
core/tauri/src/window.rs Outdated Show resolved Hide resolved
tooling/api/src/window.ts Outdated Show resolved Hide resolved
@noamzaks @amrbashir
Apply suggestions from code review
6afeb63 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
amrbashir previously approved these changes Dec 9, 2022
View reviewed changes
@FabianLars FabianLars mentioned this pull request Dec 12, 2022
Open
@FabianLars
Copy link
Member

I think we should document the default value like we do in wry: https://docs.rs/wry/latest/x86_64-pc-windows-msvc/wry/webview/trait.WebViewBuilderExtWindows.html#tymethod.with_additional_browser_args

@lucasfernog lucasfernog merged commit 3dc38b1 into tauri-apps:dev Dec 14, 2022
lucasfernog added a commit that referenced this pull request Feb 8, 2023
@lucasfernog
refactor(core): do not allow JS API to set additional browser args
ce1046a 
This was introduced in #5799, but it's dangerous to let the frontend set this option.
@lucasfernog lucasfernog mentioned this pull request Feb 8, 2023
Merged
13 tasks
This was referenced Mar 1, 2023
Closed
Closed
lucasfernog added a commit that referenced this pull request Mar 31, 2023
@lucasfernog
refactor(core): do not allow JS API to set additional browser args (#…
d788d23 
…6216)

This was introduced in #5799, but it's dangerous to let the frontend set this option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@amrbashir amrbashir amrbashir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noamzaks @FabianLars @lucasfernog @amrbashir