Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): don't panic when a crate version couldn't be parsed #5873

Merged
merged 2 commits into from
Dec 26, 2022
Merged

fix(cli): don't panic when a crate version couldn't be parsed #5873

merged 2 commits into from
Dec 26, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Dec 19, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner December 19, 2022 21:58
lucasfernog
lucasfernog reviewed Dec 26, 2022
View reviewed changes
.changes/cli-info.md Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit c260842 into dev Dec 26, 2022
@lucasfernog lucasfernog deleted the cli-info-no-lock-crate-version-panic branch December 26, 2022 14:35
@lucasfernog lucasfernog mentioned this pull request Dec 26, 2022
Open
luoffei pushed a commit to luoffei/tauri that referenced this pull request Dec 29, 2022
@amrbashir @lucasfernog @luoffei
fix(cli): don't panic when a crate version couldn't be parsed (tauri-…
7eae780 
…apps#5873)

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog