feat(windows): implement with_tooltip#5938
Merged
lucasfernog merged 9 commits intotauri-apps:devfrom Dec 31, 2022
Merged
Conversation
Signed-off-by: luofei <luoffei@outlook.com>
amrbashir
requested changes
Dec 30, 2022
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
The builder implementation is LGTM but, you also need to add set_tooltip on SystemTrayHandle structs.
Signed-off-by: luofei <luoffei@outlook.com>
amrbashir
requested changes
Dec 30, 2022
Signed-off-by: luofei <luoffei@outlook.com>
amrbashir
requested changes
Dec 30, 2022
Signed-off-by: luofei <luoffei@outlook.com>
amrbashir
requested changes
Dec 30, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Signed-off-by: luofei <luoffei@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information