Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow specifying a resource map, closes #5844 #5950

Merged
merged 15 commits into from
Jul 13, 2023
Merged

feat: allow specifying a resource map, closes #5844 #5950

merged 15 commits into from
Jul 13, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner December 31, 2022 18:33
@amrbashir amrbashir mentioned this pull request Jan 2, 2023
Closed
amrbashir
amrbashir previously approved these changes May 23, 2023
View reviewed changes
@lucasfernog lucasfernog requested a review from a team May 23, 2023 14:41
amrbashir
amrbashir previously approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the NSIS implementation and used dunce to simplify the path on WiX and NSIS

Other changes LGTM

amrbashir
amrbashir previously approved these changes May 24, 2023
View reviewed changes
@wusyong wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023
@lucasfernog lucasfernog changed the base branch from dev to 1.x June 16, 2023 16:00
@lucasfernog lucasfernog merged commit 4dd4893 into 1.x Jul 13, 2023
@lucasfernog lucasfernog deleted the feat/resources-map branch July 13, 2023 21:28
@FabianLars FabianLars mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
security: needs audit This issue/PR needs a security audit
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfernog @amrbashir @wusyong