Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): create WindowBuilder from WindowConfig #6073

Merged
merged 2 commits into from
Jan 17, 2023
Merged

feat(core): create WindowBuilder from WindowConfig #6073

merged 2 commits into from
Jan 17, 2023

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This was requested quite often in context of long-running system tray apps.

@FabianLars FabianLars requested a review from a team as a code owner January 16, 2023 14:16
@lucasfernog lucasfernog merged commit 49dff27 into dev Jan 17, 2023
@lucasfernog lucasfernog deleted the window-from-config branch January 17, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianLars @lucasfernog