Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove default features from template #6074

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: no idea tbh

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This "fixes" IDE errors complaining about a missing ../dist dir which causes confusion for new users.

I am not too happy with the note about cargo but mainly because most tauri user's don't use (much) rust and my fear would be that it cause confusion 馃

@FabianLars FabianLars requested a review from a team as a code owner January 16, 2023 18:05
@lucasfernog lucasfernog merged commit b08ae63 into dev Jan 17, 2023
@lucasfernog lucasfernog deleted the template-default-feat branch January 17, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants