Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --ci flag to signer generate, closes #6089 #6097

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jan 18, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner January 18, 2023 17:21
@lucasfernog lucasfernog changed the title fix(cli): generate unencrypted keys if TAURI_KEY_PASSWORD is not defined, closes #6089 feat(cli): add --ci flag to signer generate, closes #6089 Jan 19, 2023
@lucasfernog lucasfernog merged commit 8fb1df8 into dev Jan 19, 2023
@lucasfernog lucasfernog deleted the fix/cli/sign/unencrypted-key branch January 19, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants