Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Further improve workspace inheritance, closes #6122, #5070 #6144

Merged
merged 7 commits into from
Jan 26, 2023

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I feel like rewriting the features when the dependency is inherited would cause more harm than good so i went ahead and disabled it if needed.

@FabianLars FabianLars requested a review from a team as a code owner January 25, 2023 16:34
@lucasfernog
Copy link
Member

Tbh I don't see the harm in rewriting the workspace features too (the algorithm should be smart enough to keep other features etc etc), but I'll take this until we figure it out.

@FabianLars
Copy link
Member Author

The problem is to figure out where to add/remove features from. Imagine this setup

# workspace.toml
[workspace.dependencies]
tauri = { version = "v1", features = ["fs-all"] }

#package.toml
[dependencies]
tauri = { workspace = true, version = "v1", features = ["http-all"] }

Adding a new feature is fine, just add it to the package toml. But now imagine that fs-all needs to be disabled. This would need changes in the workspace toml file which could potentially break other tauri projects in the same workspace.

I think it's pretty hard to know the dev's intent here and to figure out a solution that doesn't cause more friction than having to rewrite it manually straight away.

@lucasfernog lucasfernog merged commit d20a728 into dev Jan 26, 2023
@lucasfernog lucasfernog deleted the inheritance branch January 26, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants