feat: Further improve workspace inheritance, closes #6122, #5070#6144
Merged
lucasfernog merged 7 commits intodevfrom Jan 26, 2023
Merged
feat: Further improve workspace inheritance, closes #6122, #5070#6144lucasfernog merged 7 commits intodevfrom
lucasfernog merged 7 commits intodevfrom
Conversation
Member
|
Tbh I don't see the harm in rewriting the workspace features too (the algorithm should be smart enough to keep other features etc etc), but I'll take this until we figure it out. |
Member
Author
|
The problem is to figure out where to add/remove features from. Imagine this setup # workspace.toml
[workspace.dependencies]
tauri = { version = "v1", features = ["fs-all"] }
#package.toml
[dependencies]
tauri = { workspace = true, version = "v1", features = ["http-all"] }Adding a new feature is fine, just add it to the package toml. But now imagine that fs-all needs to be disabled. This would need changes in the workspace toml file which could potentially break other tauri projects in the same workspace. I think it's pretty hard to know the dev's intent here and to figure out a solution that doesn't cause more friction than having to rewrite it manually straight away. |
lucasfernog
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
I feel like rewriting the features when the dependency is inherited would cause more harm than good so i went ahead and disabled it if needed.