Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gtk to 0.16 #6155

Merged
merged 9 commits into from
Jan 29, 2023
Merged

Update gtk to 0.16 #6155

merged 9 commits into from
Jan 29, 2023

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jan 27, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Rfd also needs to bump a version for gtk 0.16. I have opened a PR there: PolyMeilex/rfd#101
This PR currently uses my fork as dependency.

@wusyong wusyong requested a review from a team as a code owner January 27, 2023 08:36
@wusyong wusyong requested a review from a team as a code owner January 27, 2023 08:48
@wusyong
Copy link
Member Author

wusyong commented Jan 28, 2023

@lucasfernog Newer version of clippy is not happy at all. Should I format code to obey it in this PR?

@lucasfernog lucasfernog merged commit 7eb9aa7 into next Jan 29, 2023
@lucasfernog lucasfernog deleted the gtk16 branch January 29, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wusyong @lucasfernog