Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): web_dev_server html template serialization (fix #6165) #6166

Conversation

AlainSchneble
Copy link
Contributor

@AlainSchneble AlainSchneble commented Jan 29, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

I believe this change is safe because this serialization is already used in https://github.com/tauri-apps/tauri/pull/5247/files#diff-45b0f313a4e403c382fbd52d97cb3cc15d75f09a30a9cca633c4c6d29a24590eR83 (note that there, the function has been aliased, but it is actually the same) and hence is already used when compiling assets.

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Related issue, see #6165

Also note that according to html5ever issue servo/html5ever#464, html (template) serialization has to be handled by the crate that uses html5ever, i.e. tauri so to speak.

@AlainSchneble AlainSchneble requested a review from a team as a code owner January 29, 2023 13:43
@AlainSchneble AlainSchneble changed the title fix: web_dev_server html template serialization (fix #6165) fix(cli): web_dev_server html template serialization (fix #6165) Jan 29, 2023
@lucasfernog
Copy link
Member

We got the existing fix from kuchiki-rs/kuchiki#96, thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants