fix(cli): web_dev_server html template serialization (fix #6165)#6166
Merged
lucasfernog merged 2 commits intotauri-apps:devfrom Jan 29, 2023
Merged
Conversation
Member
|
We got the existing fix from kuchiki-rs/kuchiki#96, thanks for this PR! |
lucasfernog
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
I believe this change is safe because this serialization is already used in https://github.com/tauri-apps/tauri/pull/5247/files#diff-45b0f313a4e403c382fbd52d97cb3cc15d75f09a30a9cca633c4c6d29a24590eR83 (note that there, the function has been aliased, but it is actually the same) and hence is already used when compiling assets.
Checklist
fix: remove a typo, closes #___, #___)Other information
Related issue, see #6165
Also note that according to html5ever issue servo/html5ever#464, html (template) serialization has to be handled by the crate that uses html5ever, i.e. tauri so to speak.