-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add shadow APIs #6206
Conversation
@amrbashir maybe you meant to open this against the next branch? |
yeah my bad |
b27a0fb
to
41d92a2
Compare
not sure why the CI fails, I can't replicate the error it shows locally |
@lucasfernog are types added later? The shadow property wasn't added to the window type. |
@aleksey-hoffman did you update |
@lucasfernog my package.json looks like this: "dependencies": {
"@tauri-apps/api": "2.0.0-alpha.2",
},
"devDependencies": {
"@tauri-apps/cli": "^1.2.3",
} When I try to upgrade "@tauri-apps/cli": "2.0.0-alpha.6", I get the following error on
|
@lucasfernog my Cargo.toml looks like this: [package]
name = "app"
version = "0.1.0"
default-run = "app"
edition = "2021"
rust-version = "1.64"
[build-dependencies]
tauri-build = { version = "1.2.1", features = [] }
[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
tauri = { version = "1.2.4", features = ["path-all", "protocol-asset", "system-tray", "window-center", "window-close", "window-create", "window-hide", "window-maximize", "window-minimize", "window-print", "window-request-user-attention", "window-set-always-on-top", "window-set-cursor-grab", "window-set-cursor-icon", "window-set-cursor-position", "window-set-cursor-visible", "window-set-decorations", "window-set-focus", "window-set-fullscreen", "window-set-icon", "window-set-ignore-cursor-events", "window-set-max-size", "window-set-min-size", "window-set-position", "window-set-resizable", "window-set-size", "window-set-skip-taskbar", "window-set-title", "window-show", "window-start-dragging", "window-unmaximize", "window-unminimize"] } |
You must change |
I upgraded cli:
Then, once I tried upgrading the tauri versions I got the following error (after running either of these commands):
Error:
|
Try removing your Cargo.lock file or running |
@lucasfernog deleted lock and ran I can update to the following versions:
But trying to update to the newer once, throwing the wry Does it need a newer version of rust? I'm using |
@lucasfernog I found that the problem is caused by this plugin:
If I change the branch to |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information