Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): generate build script using NPM runner if it was used #6233

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

lucasfernog
Copy link
Member

Prevents absolute paths from being added to the generated Android Studio and Xcode projects.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Prevents absolute paths from being added to the generated Android Studio and Xcode projects.
@lucasfernog lucasfernog requested a review from a team as a code owner February 9, 2023 18:20
@lucasfernog lucasfernog merged commit 62f1526 into next Feb 10, 2023
@lucasfernog lucasfernog deleted the fix/build-script-absolute-paths branch February 10, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant