Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/tauri): upgrade open to 3.2 to fix a bug on Windows #6441

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

thep0y
Copy link
Contributor

@thep0y thep0y commented Mar 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

For specific bug details, please refer to https://github.com/Byron/open-rs/releases/tag/v4.0.0

@thep0y thep0y requested a review from a team as a code owner March 13, 2023 15:36
@FabianLars
Copy link
Member

Thanks for contributing! Unfortunately we can't merge this into the dev branch because of the MSRV bum to 1.62. We're stuck with 1.59 for dependencies that are also used on Linux :/ See the conversation here: #6332 - if we change the approach in that PR, we'll also change it for this dependency if we bump it all the way up to 1.62

p.s. upgrading dependencies is handled by the renovate bot :)

@thep0y
Copy link
Contributor Author

thep0y commented Mar 13, 2023

Downgrading open to 3.2.0 can also fix this bug, 3.2.0 can run on 1.59.

@FabianLars
Copy link
Member

Tauri should already use 3.2 - we didn't lock it so cargo update in user's project should update it to the latest 3.x release.

@FabianLars
Copy link
Member

3.4 is kinda buggy (more than 3.2 lol), so unpinning 3.2 makes this PR useless @lucasfernog

@lucasfernog
Copy link
Member

IIRC 3.4 was yanked? I'm on my phone lol @FabianLars

@FabianLars
Copy link
Member

ah you're right, nvm then ✌️

@lucasfernog lucasfernog changed the title fix(core/tauri): upgrade open to 4.0 to fix a bug on Windows fix(core/tauri): upgrade open to 3.2 to fix a bug on Windows Apr 6, 2023
@lucasfernog lucasfernog merged commit 708efbd into tauri-apps:dev Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants