Skip to content

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Mar 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner March 13, 2023 22:52
@wusyong wusyong requested a review from lucasfernog May 23, 2023 03:49
@lucasfernog
Copy link
Member

I'm not sure why but I can't apply any of the effects on the API example (tried both macOS and Windows).

@amrbashir
Copy link
Member Author

Seems to be working just fine for me with WindowBuilder and tauri.conf.json
image

Just make sure to enable transparency (decorations on Windows).

@lucasfernog
Copy link
Member

Can you share your config too @amrbashir just so I can compare

@lucasfernog
Copy link
Member

Ahh I forgot we removed transparency by default on the example. Let me check.

lucasfernog
lucasfernog previously approved these changes May 23, 2023
@lucasfernog
Copy link
Member

Ah I forgot we also need to document this on the config. And maybe it's best to put a reference on the decorations/fullscreen issue until it gets fixed, otherwise people will think the effects aren't working.

@lucasfernog lucasfernog merged commit e0f0dce into next May 23, 2023
@lucasfernog lucasfernog deleted the feat/vibrancy branch May 23, 2023 18:29
lucasfernog added a commit to tauri-apps/plugins-workspace that referenced this pull request May 23, 2023
@wusyong wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security: needs audit This issue/PR needs a security audit

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants