refactor(core): remove attohttpc client, closes #6415#6468
Merged
lucasfernog merged 2 commits intonextfrom Mar 17, 2023
Merged
Conversation
FabianLars
previously approved these changes
Mar 17, 2023
Member
FabianLars
left a comment
There was a problem hiding this comment.
fwiw i really agree with this change 😅 If we need more reasons to merge this PR, here are the first two things i found in my todo list:
https://discord.com/channels/616186924390023171/1031003062774542426/1031230486527352912 (corrupt deflate stream)
https://discord.com/channels/616186924390023171/1074836726230548551 (attohttpc causing issues in the updater, don't know specifics)
Also it will probably make adding cookie support easier (since reqwest has built-in support)
and most rust devs use reqwest which caused binary bloat because our reqwest-client flag wasn't documented good enough - tbh i wouldn't know how to solve this with docs alone, why/where would people look for that in the first place...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information