Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions of Tauri Plugin with-api template #6603

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Fix Github Actions of Tauri Plugin with-api template #6603

merged 5 commits into from
Apr 3, 2023

Conversation

Miniontoby
Copy link
Contributor

@Miniontoby Miniontoby commented Mar 31, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

check https://discord.com/channels/616186924390023171/1090989894991618171 for more info I guess

@Miniontoby Miniontoby requested a review from a team as a code owner March 31, 2023 16:50
lucasfernog
lucasfernog previously approved these changes Mar 31, 2023
@lucasfernog
Copy link
Member

@FabianLars
Copy link
Member

Also might as well update actions/checkout to v3 while we're at it.

@Miniontoby
Copy link
Contributor Author

Also might as well update actions/checkout to v3 while we're at it.

I will do that as well tomorrow for all templates

@Miniontoby
Copy link
Contributor Author

Can you add a change file like this one? https://raw.githubusercontent.com/tauri-apps/tauri/dev/.changes/cli-sign-non-interactive.md

Never used that type of stuff before.
Btw it said "A change file is added if any packages will require a version bump due to this PR", but there are no packages to be bumped!

@FabianLars
Copy link
Member

The cli will be bumped for this (patch). Here's an example change file for cli changes: https://github.com/tauri-apps/tauri/blob/dev/.changes/cli-info.md

@Miniontoby
Copy link
Contributor Author

Oke, I will look at it tomorrow and then I will also have my commits signed.

@Miniontoby
Copy link
Contributor Author

Let me know if anything else should be changed as well or else just merge it if possible

FabianLars
FabianLars previously approved these changes Apr 1, 2023
FabianLars
FabianLars previously approved these changes Apr 1, 2023
@Miniontoby
Copy link
Contributor Author

Maybe I should add a permissions block to the audit workflow(s) so the users don't have to manually change stuff for the audit token to be able to do what it is supposed to do.

@lucasfernog lucasfernog merged commit a926b49 into tauri-apps:dev Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants