feat(core): expose Wry's with_incognito to Tauri on the WindowBuilder::incognito function.#6767
Merged
amrbashir merged 1 commit intotauri-apps:nextfrom Jun 6, 2023
Merged
Conversation
Hyphrio
changed the title
with_incognito to Tauri on the WebViewBuilder::enable_incognito function.
Hyphrio
changed the title
with_incognito to Tauri on the WebViewBuilder::enable_incognito function.with_incognito to Tauri on the WindowBuilder::enable_incognito function.
Hyphrio
changed the title
with_incognito to Tauri on the WindowBuilder::enable_incognito function.with_incognito to Tauri on the WindowBuilder::enable_incognito function.
Hyphrio
changed the title
with_incognito to Tauri on the WindowBuilder::enable_incognito function.with_incognito to Tauri on the WindowBuilder::enable_incognito function.
amrbashir
requested changes
Apr 24, 2023
Hyphrio
changed the title
with_incognito to Tauri on the WindowBuilder::enable_incognito function.with_incognito to Tauri on the WindowBuilder::incognito function.
Contributor
Author
|
I'm not sure if the JS api works so that'll need some testing. |
Contributor
Author
|
I think the JS api is broken on all versions of Tauri it seems. |
Contributor
Author
|
I'll put this back to Draft until I finish rebasing. |
Contributor
Author
|
Alright, already rebased. |
amrbashir
requested changes
Jun 5, 2023
Contributor
Author
|
I think after this I'll probably pulling a small PR for the JS api, but if you can do it that would be nice |
amrbashir
previously approved these changes
Jun 6, 2023
Co-authored-by: Hyphrio <notmynn@proton.me>
amrbashir
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
While
WebViewBuilder::data_directorycould simulate incognito mode by setting this to a temporary directory, that is annoying to use and error-prone as users could forget deleting the directory, thus creating large unnecessary directories, filling up the user's storage.This PR merely exposes
with_incognitofrom tauri-apps/wry#916 to Tauri though the newenable_incognitofunction at theWindowBuilder, which would allow for a real incognito mode that would be useful for things that need incognito mode, like webview sign-ins.NOTE: Requires Wry 0.27.3 or higher, thus this should be merged for 2.0.