Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): Add Spanish and SpanishInternational to NSIS languages (closes #6852, resubmits #6860) #6871

Merged
merged 1 commit into from
May 6, 2023

Conversation

LuisFerLCC
Copy link
Contributor

NOTE: This is a resubmission of #6860. I forgot to sign a commit so I had to re-fork the repo. I already followed the instructions given to me last time so that this PR will hopefully pass right away.

Spanish is one of the listed languages on https://github.com/kichik/nsis/tree/9465c08046f00ccb6eda985abbdbf52c275c6c4d/Contrib/Language%20files, yet it's not available for the Tauri NSIS bundle. Large-scale applications made with Tauri may need to have Spanish as an available language on the installer.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

@LuisFerLCC LuisFerLCC requested a review from a team as a code owner May 5, 2023 18:44
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

@wusyong wusyong merged commit 422b481 into tauri-apps:dev May 6, 2023
@FabianLars FabianLars linked an issue May 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

[feat] Add Spanish to the available languages (Windows NSIS)
3 participants