Skip to content

refactor(build): remove WindowsAttributes::sdk_dir - #6886

Merged
lucasfernog merged 2 commits into
nextfrom
refactor/remove-deprecated-api
May 6, 2023
Merged

refactor(build): remove WindowsAttributes::sdk_dir#6886
lucasfernog merged 2 commits into
nextfrom
refactor/remove-deprecated-api

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog
lucasfernog requested a review from a team as a code owner May 6, 2023 20:17

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip

@lucasfernog
lucasfernog merged commit 5a768d5 into next May 6, 2023
@lucasfernog
lucasfernog deleted the refactor/remove-deprecated-api branch May 6, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants