Skip to content

feat(cli): update android template to gradle 8.0#6890

Merged
amrbashir merged 4 commits intonextfrom
gradle-8
May 12, 2023
Merged

feat(cli): update android template to gradle 8.0#6890
amrbashir merged 4 commits intonextfrom
gradle-8

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented May 7, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner May 7, 2023 13:50
wusyong
wusyong requested changes May 7, 2023
View reviewed changes
@wusyong wusyong self-requested a review May 9, 2023 17:15
@wusyong wusyong self-requested a review May 9, 2023 17:51
@wusyong
Copy link
Member

wusyong commented May 9, 2023

Android CI seems failed. Can you take a look if you have sometime tmr?

@amrbashir
Copy link
Member Author

amrbashir commented May 10, 2023

fixed in #6925

@amrbashir
Copy link
Member Author

amrbashir commented May 12, 2023

CI is fixed in next branch, I will just go ahead and merge

@amrbashir amrbashir merged commit 5a9307d into next May 12, 2023
@amrbashir amrbashir deleted the gradle-8 branch May 12, 2023 11:06
@wusyong wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wusyong wusyong Awaiting requested review from wusyong

Assignees

No one assigned

Labels

security: needs audit This issue/PR needs a security audit

Projects

Roadmap
Status: 🔎 In audit

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amrbashir @wusyong