Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove app module #6895

Merged
merged 4 commits into from
May 8, 2023
Merged

refactor(core): remove app module #6895

merged 4 commits into from
May 8, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

tauri-apps/plugins-workspace#345

@lucasfernog lucasfernog requested a review from a team as a code owner May 7, 2023 20:22
@lucasfernog lucasfernog requested a review from wusyong May 8, 2023 12:34
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. But I'll need people to review tauri-apps/plugins-workspace#345.
@tauri-apps/wg-tauri @tauri-apps/plugin-maintainers Can you review it if you have some time?

@lucasfernog
Copy link
Member Author

For now the plugin is just code moved from core, so it's easy to review.

@lucasfernog
Copy link
Member Author

The actual refactor we have to do on some plugins (mostly fs plugin) will be done later.

@lucasfernog lucasfernog merged commit 3245d14 into next May 8, 2023
@lucasfernog lucasfernog deleted the refactor/remove-app branch May 8, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants