Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci and cleanup leftovers #6925

Merged
merged 31 commits into from
May 13, 2023
Merged

chore: fix ci and cleanup leftovers #6925

merged 31 commits into from
May 13, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 10, 2023

  1. removed leftover feature flags
  2. remove zip/extract apis which are not used anymore
  3. removed leftoever scopes
  4. removed leftover allowlist
  5. updated the example api
  6. moved updater config under bundle key and remove unneeded bits
  7. removed handling of APPIMAGE_BUNDLE_XDG_OPEN env var in CLI, since the shell APIs are moved to its plugins. we either allow plugins to hook into the build pipeline or users specify it before building.
  8. removed allowlist config
  9. moved allowlist > protocol to security> asset_protocol
  10. removed file_move api

Questions

  1. there is now a EventLoopMessage enum with 0 variants, not sure what to do about?
  2. there is a process-relaunch-dangerous-allow-symlink-macos feature flag that existed, probably for the removed process.relaunch JS API, is it still needed?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

1. removed leftover feature flags
2. remove zip/extract apis which are not used anymore
3. removed leftoever scopes
4. removed leftover allowlist and updater options
5. updated the example api
@amrbashir amrbashir requested a review from a team as a code owner May 10, 2023 01:03
@amrbashir amrbashir changed the title Refactor/cleanup chore: fix ci and cleanup leftovers May 10, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: pkg@5.2.1

@lucasfernog
Copy link
Member

EventLoopMessage should be removed.
process-relaunch-dangerous-allow-symlink-macos is still used in tauri-utils.

@wusyong wusyong requested a review from lucasfernog May 11, 2023 06:14
@lucasfernog lucasfernog marked this pull request as draft May 11, 2023 15:31
@lucasfernog lucasfernog marked this pull request as ready for review May 13, 2023 04:45
@amrbashir amrbashir merged commit e1e85dc into next May 13, 2023
36 checks passed
@amrbashir amrbashir deleted the refactor/cleanup branch May 13, 2023 10:48
@wusyong wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security: needs audit This issue/PR needs a security audit
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

None yet

3 participants