Skip to content

feat: adding copyright text to BrandingText#7001

Merged
wusyong merged 1 commit intotauri-apps:devfrom
simonhyll:feat/nsis-branding
May 19, 2023
Merged

feat: adding copyright text to BrandingText#7001
wusyong merged 1 commit intotauri-apps:devfrom
simonhyll:feat/nsis-branding

Conversation

@simonhyll
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I added the copyright field from the bundle configuration as BrandingText in NSIS in order for users to be able to get rid of the Nullsoft Install System vX.X.X text from their installer.

I wouldn't consider BrandingText to be a breaking change. If you leave the copyright field blank you still get the Nullsoft message. If you set the copyright text to something, it'll show up there.

@simonhyll simonhyll requested a review from a team as a code owner May 19, 2023 07:39
@wusyong wusyong merged commit fc7f9eb into tauri-apps:dev May 19, 2023
@simonhyll simonhyll deleted the feat/nsis-branding branch May 19, 2023 11:42
@wusyong wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023
@chippers chippers added security: reviewed This issue/PR has been review by wg-security and removed security: needs audit This issue/PR needs a security audit labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security: reviewed This issue/PR has been review by wg-security

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants