Skip to content

feat(bundler/NSIS): Add Turkish to supported NSIS languages#7018

Merged
amrbashir merged 1 commit intotauri-apps:devfrom
agmmnn:dev
May 21, 2023
Merged

feat(bundler/NSIS): Add Turkish to supported NSIS languages#7018
amrbashir merged 1 commit intotauri-apps:devfrom
agmmnn:dev

Conversation

@agmmnn
Copy link
Contributor

@agmmnn agmmnn commented May 20, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@agmmnn agmmnn requested a review from a team as a code owner May 20, 2023 13:50
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@amrbashir
Copy link
Member

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

@lucasfernog
Copy link
Member

First commit is still unsigned :(

@agmmnn
Copy link
Contributor Author

agmmnn commented May 21, 2023

Is it ok now?

@FabianLars
Copy link
Member

Yep, thank you :)

@amrbashir amrbashir merged commit ac18394 into tauri-apps:dev May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

4 participants