Skip to content

feat: current_version feature#7026

Merged
amrbashir merged 4 commits intotauri-apps:devfrom
amirHdev:current_version
May 23, 2023
Merged

feat: current_version feature#7026
amrbashir merged 4 commits intotauri-apps:devfrom
amirHdev:current_version

Conversation

@amirHdev
Copy link
Contributor

fixes : #6995

As I see in this example :

  let _webview = WebViewBuilder::new(window)?
    .with_url("https://tauri.studio")?
    .build()?;

it will return WindowWrapper and suppose current_version can fetch with it . but with collaborator guide can move it .

@amirHdev amirHdev requested a review from a team as a code owner May 21, 2023 17:08
@wusyong wusyong added the status: needs review A maintainer must review this code label May 22, 2023
@lucasfernog
Copy link
Member

To add a new webview/window function you actually need to change the tauri-runtime and tauri crates. So the webview_version function would need to be added under here, here and here.

@amrbashir
Copy link
Member

amrbashir commented May 22, 2023

It doesn't need to be a method on the Window type, it just needs to be re-exported in tauri-runtime-wry then re-exported in tauri

@lucasfernog
Copy link
Member

Ahh right. Easier that way.

@amirHdev
Copy link
Contributor Author

@lucasfernog you can review it !

@amrbashir
Copy link
Member

amrbashir commented May 23, 2023

you need to also add a file like this one https://github.com/tauri-apps/tauri/blob/dev/.changes/appimage-follow-symlinks.md with a quick summary about this change/addition.

@amirHdev
Copy link
Contributor Author

@amrbashir Done .

amrbashir
amrbashir previously approved these changes May 23, 2023
@amrbashir amrbashir merged commit 4c39e46 into tauri-apps:dev May 23, 2023
@lucasfernog
Copy link
Member

Nice one @Mehrbod2002 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review A maintainer must review this code

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

[feat] Expose Wry::webview_version through tauri

4 participants