Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/android): fallback to all targets #7028

Merged
merged 1 commit into from
May 22, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 22, 2023

fix regression introduced in d03e47d

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner May 22, 2023 14:42
@simonhyll
Copy link
Sponsor Contributor

Tested and seems to fix the issue I encountered.
Great work @amrbashir ! 😄

@amrbashir amrbashir merged commit 3f4c4ce into next May 22, 2023
12 checks passed
@amrbashir amrbashir deleted the fix/cli/android/fallback-all branch May 22, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

None yet

3 participants