Skip to content

Conversation

@Raphiiko
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Trying to build an NSIS installer with Japanese enabled currently fails with the following error:

!include: error in script: "Japanese.nsh" on line 21
Error in script "D:\a\Oyasumi\Oyasumi\src-tauri\target\debug\nsis\x64\installer.nsi" on line 342 -- aborting creation process
Error failed to bundle project: `The system cannot find the file specified. (os error 2)`

@Raphiiko Raphiiko requested a review from a team as a code owner May 30, 2023 19:06
FabianLars
FabianLars previously approved these changes May 30, 2023
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, that one's on me :/ Thanks for the fix!!

Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@FabianLars FabianLars merged commit 4d4b72b into tauri-apps:dev Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants