Skip to content

feat(api): expose window target option on event APIs #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

feat(api): expose window target option on event APIs #7132

merged 2 commits into from
Jun 5, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is meant to remove the duplicated logic from https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/window/guest-js/event.ts

@lucasfernog lucasfernog requested a review from a team as a code owner June 5, 2023 10:00
@wusyong wusyong added status: needs review A maintainer must review this code security: needs feedback This issue/PR needs feeback from wg-security labels Jun 5, 2023
@lucasfernog lucasfernog requested a review from amrbashir June 5, 2023 13:18
@lucasfernog lucasfernog merged commit 9e3a18e into next Jun 5, 2023
@lucasfernog lucasfernog deleted the feat/event-api branch June 5, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
security: needs feedback This issue/PR needs feeback from wg-security status: needs review A maintainer must review this code
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfernog @amrbashir @wusyong