Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove attohttpc in favor of reqwest #7143

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Conversation

FabianLars
Copy link
Member

ref: for example #6415 and #5344

What kind of change does this PR introduce?

  • Bugfix - yes i count this as a bugfix considering how many issues users had with atto
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No, well... Technically it is because of the enum variants but i think it's worth it.

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

@FabianLars FabianLars requested a review from a team as a code owner June 6, 2023 14:58
@FabianLars
Copy link
Member Author

that clippy json output gives me a headache lol. Also, no idea why i couldn't trigger that warning locally 🤔

@lucasfernog
Copy link
Member

Usually that happens when I don't have latest cargo. Or not using the right feature flags.

@FabianLars
Copy link
Member Author

ahhhhh, i was in the root dir and not in core/tauri ...

core/tauri/src/api/error.rs Outdated Show resolved Hide resolved
.changes/remove-attohttpc.md Outdated Show resolved Hide resolved
FabianLars and others added 2 commits June 6, 2023 17:53
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
@lucasfernog lucasfernog merged commit db7c5fb into dev Jun 6, 2023
@lucasfernog lucasfernog deleted the remove-atto branch June 6, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants