refactor(core): Remove attohttpc in favor of reqwest#7143
Merged
lucasfernog merged 6 commits intodevfrom Jun 6, 2023
Merged
Conversation
Member
Author
|
that clippy json output gives me a headache lol. Also, no idea why i couldn't trigger that warning locally 🤔 |
Member
|
Usually that happens when I don't have latest cargo. Or not using the right feature flags. |
Member
Author
|
ahhhhh, i was in the root dir and not in core/tauri ... |
lucasfernog
requested changes
Jun 6, 2023
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
lucasfernog
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: for example #6415 and #5344
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)