Skip to content

fix(core/path): change sep and delimiter to functions #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amrbashir merged 6 commits into from
Jun 8, 2023
Merged

fix(core/path): change sep and delimiter to functions #7160

amrbashir merged 6 commits into from
Jun 8, 2023

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 7, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 7, 2023 18:29
@lucasfernog
Copy link
Member

lucasfernog commented Jun 7, 2023

You're setting the values to __TAURI_PATH__ but that is never defined. I'm pushing a change.

@amrbashir
Copy link
Member Author

amrbashir commented Jun 8, 2023

thanks

@amrbashir amrbashir merged commit 6d3f313 into next Jun 8, 2023
@amrbashir amrbashir deleted the refactor/path-sep-delimiter branch June 8, 2023 00:40
@phudtran phudtran mentioned this pull request May 21, 2024
Closed
yosmirnjr
yosmirnjr reviewed Oct 10, 2024
View reviewed changes
Copy link

@yosmirnjr yosmirnjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

+1 more reviewer

@yosmirnjr yosmirnjr yosmirnjr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: 🔎 In audit

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amrbashir @lucasfernog @yosmirnjr