fix(core): fix nsis updater unable to launch installers requiring elevation, closes #7184#7185
Merged
Merged
Conversation
Contributor
Author
|
Edit: nvm, I believe this was unrelated. |
amrbashir
requested changes
Jun 13, 2023
Member
amrbashir
left a comment
There was a problem hiding this comment.
thanks for you contribution
amrbashir
reviewed
Jun 13, 2023
amrbashir
approved these changes
Jun 19, 2023
amrbashir
added a commit
to tauri-apps/plugins-workspace
that referenced
this pull request
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This PR should fix the issue posted in #7184. I am not quite sure if this is the correct solution, but it seems to fix the problem for me.
Of course this does not solve the problem for existing builds, but I don't see a way for that to be fixed. Users will have to update once by launching the old version as administrator in order to update, or by reinstalling the new version.