Skip to content

feat: add navigate method#7235

Merged
lucasfernog merged 1 commit intotauri-apps:devfrom
jhutchins:feat/add-navigate-method
Jun 20, 2023
Merged

feat: add navigate method#7235
lucasfernog merged 1 commit intotauri-apps:devfrom
jhutchins:feat/add-navigate-method

Conversation

@jhutchins
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@jhutchins jhutchins requested a review from a team as a code owner June 17, 2023 13:22
@jhutchins jhutchins force-pushed the feat/add-navigate-method branch 5 times, most recently from 4b99b2f to 7e9b37c Compare June 17, 2023 15:36
@lucasfernog
Copy link
Copy Markdown
Member

I think we can target this for the 1.x branch instead so it lands on v1.5.

Comment thread core/tauri/src/window.rs Outdated
@jhutchins jhutchins force-pushed the feat/add-navigate-method branch from 7e9b37c to 6593bcf Compare June 18, 2023 18:49
@jhutchins jhutchins requested a review from lucasfernog June 18, 2023 18:51
@jhutchins jhutchins force-pushed the feat/add-navigate-method branch from 6593bcf to 3193e69 Compare June 19, 2023 15:46
@wusyong wusyong added the status: needs review A maintainer must review this code label Jun 20, 2023
@lucasfernog
Copy link
Copy Markdown
Member

Perfect!

@lucasfernog lucasfernog merged commit 2a000e1 into tauri-apps:dev Jun 20, 2023
@kanatapple
Copy link
Copy Markdown
Contributor

@lucasfernog
Will this feature ship in v1.5?
If so, when will v1.5 be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review A maintainer must review this code

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

4 participants