Skip to content

feat: respect base tag's target attribute, closes #7285#7344

Merged
amrbashir merged 3 commits into
1.xfrom
feat/base-tag-target
Jul 11, 2023
Merged

feat: respect base tag's target attribute, closes #7285#7344
amrbashir merged 3 commits into
1.xfrom
feat/base-tag-target

Conversation

@amrbashir
Copy link
Copy Markdown
Member

@amrbashir amrbashir commented Jul 3, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner July 3, 2023 18:13
wusyong
wusyong previously approved these changes Jul 10, 2023
@amrbashir amrbashir merged commit 757e959 into 1.x Jul 11, 2023
@amrbashir amrbashir deleted the feat/base-tag-target branch July 11, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants